Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve extension (de)selection in Quarkus wizard #989

Merged
merged 2 commits into from
Jul 3, 2023
Merged

feat: improve extension (de)selection in Quarkus wizard #989

merged 2 commits into from
Jul 3, 2023

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Jul 1, 2023 •
edited
Loading

  • (de)select extension on double-click in extensions treeview
  • deselect extension on double-click in selected extensions list
  • deselect selection of extension on DELETE or BACKSPACE keypress in selected extensions list

Jul-01-2023 22-41-24

@fbricon fbricon added enhancement New feature or request quarkus Quarkus support wizard labels Jul 1, 2023
@fbricon fbricon added this to the 1.22.0 milestone Jul 1, 2023
@fbricon fbricon requested a review from adietish July 1, 2023 20:48
@fbricon fbricon self-assigned this Jul 1, 2023
@fbricon fbricon force-pushed the improve-extension-selection branch 3 times, most recently from 9a4da4e to 459399e Compare July 2, 2023 21:16
@fbricon fbricon marked this pull request as draft July 2, 2023 21:30
@fbricon fbricon force-pushed the improve-extension-selection branch from 459399e to 75928f0 Compare July 3, 2023 10:22
@fbricon fbricon marked this pull request as ready for review July 3, 2023 10:24
@fbricon
Copy link
Contributor Author

fbricon commented Jul 3, 2023

Updated commit to handle cases when the treeview is filtered, and selected extensions are not visible in the treeview. Removing them (double-click or delete) now works as expected.

@sonarcloud
Copy link

sonarcloud bot commented Jul 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

adietish
adietish approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@adietish adietish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely for me, LGTM.
Extracted classes, methods to improve code readability a bit.

@adietish
Copy link
Contributor

adietish commented Jul 3, 2023 •
edited
Loading

@fbricon added a commit on top for a bit of cleanup (#getComponent was 140 lines long, still is 100 with my change). Please have a look if you agree.

@fbricon fbricon merged commit 1c9f7f7 into redhat-developer:main Jul 3, 2023
11 of 12 checks passed
@fbricon
Copy link
Contributor Author

fbricon commented Jul 3, 2023

@adietish thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adietish adietish adietish approved these changes

Assignees

@fbricon fbricon

Labels
enhancement New feature or request quarkus Quarkus support wizard
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fbricon @adietish